The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
holocene	Ready	Preview, Comment	Jun 16, 2026 7:50pm

@rosanusi just FYI the PR statement is incorrect about two things:

1. There IS a visual change, though minor:

Before:

After:

Explanation:

The icon itself never changed (16×16). Everything below flows from p-1 (4px padding on every side) making the button bigger, which then ripples out to the chip because the chip is sized to its contents.

Width: 85 → 93px (+8px)

• The remove button was just the bare 16px icon (padding: 0). p-1 adds 4px left + 4px right → button width becomes 4 + 16 + 4 = 24px. That's +8px of button width.
• The chip is w-fit (shrink-to-fit) and lays its children out in a row, so the chip's width is the sum of its children. An 8px-wider button means an 8px-wider chip. The label and the inter-item gap-1 are unchanged, so the increase passes straight through: +8px.

Height: 33 → 36px (+3px)

The chip's height = (tallest child) + its own vertical padding. The chip has p-1.5 = 6px top + 6px bottom = 12px.

• Before: the two children were the label text and the button. The label's line box is text-sm (14px) × leading-[1.5] ≈ 21px; the button was 16px. Tallest = 21px (the text). Chip = 21 + 12 = 33px.
• After: p-1 makes the button 4 + 16 + 4 = 24px tall. Now the button (24px) is taller than the text line (21px), so it becomes the tallest child. Chip = 24 + 12 = 36px → +3px.

So the height grew not because the chip's padding changed, but because the padded button overtook the text as the tallest item in the row.

Why min-h-7 didn't absorb it

The PR assumed the chip sits at min-h-7 (28px) with room to spare for a 24px button. But min-h-7 is a minimum, not a maximum — the chip's natural height (33px before, 36px after) already exceeds 28px, so that rule never engaged and couldn't cap the growth.

(inline-flex items-center justify-center is a secondary effect: it centers the 16px icon inside the now-24px box and removes any inline whitespace, but the padding is what drives the size change.)

2. Testing instructions are wrong.

"Visit the workflows list with active filter chips visible. Inspect the chip remove button: confirm 24×24."

But the "filter chips" on the workflows list are not that component. Tracing the render path, the workflows filter bar (filter-list.svelte:104) builds its active-filter pills from DropdownFilterChip and StatusFilterChip, which are Button-based dropdown pills (chevron ▾, click-to-edit) — they have no × remove button and no .chip markup at all.

holocene/chip.svelte only renders through ChipInput and combobox (multiselect). The most direct route:

• /namespaces/default/workflows/start-workflow → Search Attributes → Add a search attribute, set its type to "Keyword List" → the value field becomes a chip input; each entered value renders a real Chip with the enlarged × remove button.